Add RuntimeService::block_runtime_code_heap_pages #1787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
twiggy diff reportDifference in .wasm size before and after this pull request. |
|
Don't ask me why adding an unused method increases the size of the binary. |
melekes
reviewed
Jan 18, 2022
melekes
reviewed
Jan 18, 2022
| .input_iter_unordered() | ||
| .find(|block| block.user_data.hash == *block_hash) | ||
| .and_then(|block| block.async_op_user_data)? | ||
| .unwrap(), |
There was a problem hiding this comment.
is it always safe to unwrap here?
|
I'm going to close this. It's only 40 lines of code with a merge conflict. While these lines of code may be useful in the distant future, it's better to clean up the list of PRs at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1769
This PR will fail CI because of an unused function warning, but it paves the way for #1769.